Conversation
Summary of ChangesHello @scosman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the documentation for the Kiln Python SDK by introducing a dedicated section on integrating with telemetry and MLOps platforms. The update provides users with clear guidance on leveraging the SDK's capabilities for trace tracking and observability through its LiteLLM dependency, thereby improving the discoverability and utility of these features. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
WalkthroughDocumentation update to the README file adding a new subsection about telemetry and MLOps integrations, describing supported providers including OpenTelemetry, Braintrust, MLFlow, and LangFuse with references. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds documentation for connecting the Python SDK to telemetry and MLOps platforms. The changes are confined to libs/core/README.md, where a new section is added to explain the integration via LiteLLM and provides links to relevant documentation. The additions are clear and valuable. I have one suggestion to improve a link for better usability.
📊 Coverage ReportOverall Coverage: 91% Diff: origin/main...HEADNo lines with coverage information in this diff.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@libs/core/README.md`:
- Line 445: Change the markdown link text "LangFuse" to use the canonical
product casing "Langfuse" in the README entry (update the link text inside the
list item currently showing
"[LangFuse](https://docs.litellm.ai/docs/observability/langfuse_otel_integration)"
to
"[Langfuse](https://docs.litellm.ai/docs/observability/langfuse_otel_integration)").
Ensure only the displayed text is changed, not the URL.
- Line 436: Update the Markdown heading "## Connecting to Telemetry / MLOps
(OpenTelemetry, Braintrust, etc)" to include the missing period after "etc"
(i.e., change to "etc.") so it follows American English convention; make the
change in the README heading text exactly where the heading string appears to
ensure links/anchors remain valid.
|
|
||
| While Kiln is designed for deploying to LlamaIndex, you don't need to use it. The `iter_llama_index_nodes` returns a `TextNode` object which includes all the data you need to build a RAG index in any stack: embedding, text, document name, chunk ID, etc. | ||
|
|
||
| ## Connecting to Telemetry / MLOps (OpenTelemetry, Braintrust, etc) |
There was a problem hiding this comment.
Minor: missing period after etc in section heading.
The static analysis tool flags this correctly — American English convention requires etc. (with a period).
✏️ Proposed fix
-## Connecting to Telemetry / MLOps (OpenTelemetry, Braintrust, etc)
+## Connecting to Telemetry / MLOps (OpenTelemetry, Braintrust, etc.)The trailing period is stripped by GitHub's anchor-slug algorithm, so the TOC link at Line 51 (#connecting-to-telemetry--mlops-opentelemetry-braintrust-etc) remains valid after this change.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ## Connecting to Telemetry / MLOps (OpenTelemetry, Braintrust, etc) | |
| ## Connecting to Telemetry / MLOps (OpenTelemetry, Braintrust, etc.) |
🧰 Tools
🪛 LanguageTool
[style] ~436-~436: In American English, abbreviations like “etc.” require a period.
Context: ...try / MLOps (OpenTelemetry, Braintrust, etc) You can connect the Kiln SDK to a wid...
(ETC_PERIOD)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@libs/core/README.md` at line 436, Update the Markdown heading "## Connecting
to Telemetry / MLOps (OpenTelemetry, Braintrust, etc)" to include the missing
period after "etc" (i.e., change to "etc.") so it follows American English
convention; make the change in the README heading text exactly where the heading
string appears to ensure links/anchors remain valid.
| - [OpenTelemetry](https://docs.litellm.ai/docs/observability/opentelemetry_integration) | ||
| - [Braintrust](https://docs.litellm.ai/docs/observability/braintrust) | ||
| - [MLFlow](https://docs.litellm.ai/docs/observability/mlflow) | ||
| - [LangFuse](https://docs.litellm.ai/docs/observability/langfuse_otel_integration) |
There was a problem hiding this comment.
Nit: casing inconsistency — LangFuse → Langfuse.
The official product name (per its GitHub repo langfuse/langfuse and the LiteLLM docs title "Langfuse OpenTelemetry Integration") is Langfuse with a lowercase f. The other three entries use the providers' canonical capitalisation, so this one stands out.
✏️ Proposed fix
-- [LangFuse](https://docs.litellm.ai/docs/observability/langfuse_otel_integration)
+- [Langfuse](https://docs.litellm.ai/docs/observability/langfuse_otel_integration)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - [LangFuse](https://docs.litellm.ai/docs/observability/langfuse_otel_integration) | |
| - [Langfuse](https://docs.litellm.ai/docs/observability/langfuse_otel_integration) |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@libs/core/README.md` at line 445, Change the markdown link text "LangFuse" to
use the canonical product casing "Langfuse" in the README entry (update the link
text inside the list item currently showing
"[LangFuse](https://docs.litellm.ai/docs/observability/langfuse_otel_integration)"
to
"[Langfuse](https://docs.litellm.ai/docs/observability/langfuse_otel_integration)").
Ensure only the displayed text is changed, not the URL.
2 participants
Summary by CodeRabbit