Skip to content

Commit

Permalink
🚧Perform various improvements (#154)
Browse files Browse the repository at this point in the history
* Start work for issue #153

* docs: move location of release notes

* ci: update workflows

asdf

* ide: update and improve various confgs

* ci: remove deno scripts that are not needed anymore

* ci: setup renovate for dependency management

* docs: update project readme

* ci: improve status check display names

* ci: simple workflow input improvement

* ide: update tab settings

* ci: update reusable workflow versions and workflow command syntax
  • Loading branch information
CalvinWilkinson authored Jul 21, 2023
1 parent b98838d commit 72215fa
Show file tree
Hide file tree
Showing 29 changed files with 271 additions and 515 deletions.
50 changes: 35 additions & 15 deletions .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,10 @@ indent_style = space
[*.{cs,csx,vb,vbx}]
indent_size = 4
insert_final_newline = true
charset = utf-8-bom


###############################
# .NET Coding Conventions #
###############################
[*.{cs,vb}]
# Organize usings
dotnet_sort_system_directives_first = true

Expand Down Expand Up @@ -63,7 +60,7 @@ dotnet_naming_style.pascal_case_style.capitalization = pascal_case
# Use PascalCase for constant fields
dotnet_naming_rule.constant_fields_should_be_pascal_case.severity = warning
dotnet_naming_rule.constant_fields_should_be_pascal_case.symbols = constant_fields
dotnet_naming_rule.constant_fields_should_be_pascal_case.style = pascal_case_style
dotnet_naming_rule.constant_fields_should_be_pascal_case.style = pascal_case_style
dotnet_naming_symbols.constant_fields.applicable_kinds = field
dotnet_naming_symbols.constant_fields.applicable_accessibilities = *
dotnet_naming_symbols.constant_fields.required_modifiers = const
Expand All @@ -76,7 +73,16 @@ dotnet_naming_symbols.constant_fields.required_modifiers = const
# IDE0060: Remove unused parameter
dotnet_code_quality_unused_parameters = all:warning

[*.cs]
dotnet_style_operator_placement_when_wrapping = beginning_of_line
tab_width = 4
end_of_line = crlf
dotnet_style_prefer_simplified_boolean_expressions = true:suggestion
dotnet_style_prefer_compound_assignment = true:suggestion
dotnet_style_prefer_simplified_interpolation = true:suggestion

# IDE0059: Unnecessary assignment of a value
csharp_style_unused_value_assignment_preference = discard_variable:warning

# var preferences
csharp_style_var_for_built_in_types = true:warning
csharp_style_var_when_type_is_apparent = true:warning
Expand All @@ -89,6 +95,8 @@ csharp_style_expression_bodied_operators = true:warning
csharp_style_expression_bodied_properties = true:warning
csharp_style_expression_bodied_indexers = true:warning
csharp_style_expression_bodied_accessors = true:warning
csharp_style_expression_bodied_lambdas = true:warning
csharp_style_expression_bodied_local_functions = true:warning

# Pattern matching preferences
csharp_style_pattern_matching_over_is_with_cast_check = true:warning
Expand All @@ -108,9 +116,14 @@ csharp_prefer_simple_default_expression = true:warning
csharp_style_pattern_local_over_anonymous_function = true:warning
csharp_style_inlined_variable_declaration = true:warning

csharp_style_prefer_method_group_conversion = true:silent
csharp_style_prefer_top_level_statements = true:silent

# IDE0057: Use range operator
csharp_style_prefer_range_operator = true:warning

csharp_style_namespace_declarations = file_scoped:warning

###############################
# C# Formatting Rules #
###############################
Expand Down Expand Up @@ -144,7 +157,6 @@ csharp_space_between_method_call_empty_parameter_list_parentheses = false
# Wrapping preferences
csharp_preserve_single_line_blocks = true


# IDE0051: Remove unused private members
dotnet_diagnostic.IDE0051.severity = warning

Expand All @@ -157,23 +169,31 @@ csharp_style_unused_value_assignment_preference = discard_variable:warning
# SA1503: Braces should not be omitted
dotnet_diagnostic.SA1503.severity = warning

# SA1101: Prefix local calls with this
# Prefix local calls with this
dotnet_diagnostic.SA1101.severity = none

# SA1116: Split parameters should start on line after declaration
# Split parameters should start on line after declaration
dotnet_diagnostic.SA1116.severity = warning

# SA1516: Elements should be separated by blank line
# Elements should be separated by blank line
dotnet_diagnostic.SA1516.severity = none

# SA1011: Closing square brackets should be spaced correctly
# Closing square brackets should be spaced correctly
dotnet_diagnostic.SA1011.severity = none

# SA0001: XML comment analysis is disabled due to project configuration
# XML comment analysis is disabled due to project configuration
dotnet_diagnostic.SA0001.severity = none

# SA1200: A C# using directive is placed outside of a namespace element
dotnet_diagnostic.SA1200.severity = none
# An element within a C# code file is out of order within regard to access level, in relation to other elements in the code
dotnet_diagnostic.SA1202.severity = warning

dotnet_diagnostic.CA1852.severity = warning

# Do not guard 'Dictionary.Remove(key)' with 'Dictionary.ContainsKey(key)'
dotnet_diagnostic.CA1853.severity = warning

csharp_prefer_simple_using_statement = true:suggestion

# SA1309: A field name in C# begins with an underscore
dotnet_diagnostic.SA1309.severity = warning
# Using directives must be placed inside of a namespace declaration
# IDE0065: Misplaced using directive
csharp_using_directive_placement = inside_namespace
34 changes: 0 additions & 34 deletions .github/cicd/ChalkColor.ts

This file was deleted.

96 changes: 0 additions & 96 deletions .github/cicd/RunnerService.ts

This file was deleted.

42 changes: 0 additions & 42 deletions .github/cicd/validate-notes.ts

This file was deleted.

53 changes: 0 additions & 53 deletions .github/cicd/validate-tag.ts

This file was deleted.

Loading

0 comments on commit 72215fa

Please sign in to comment.