Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support more join case #204

Merged
merged 4 commits into from
Apr 10, 2024
Merged

feat: support more join case #204

merged 4 commits into from
Apr 10, 2024

Conversation

KKould
Copy link
Member

@KKould KKould commented Apr 10, 2024 •
edited
Loading

What problem does this PR solve?

  • reconstruct the alias mechanism to ensure correctness during Join
  • support Natural Join
  • support multiple from(to Cross Join)
  • when Using and Natural Join, the same columns are automatically removed (Fixme: JoinType needs to be supported to decide whether to use the columns of the left table or the right table Fix: the fields output by Using are not determined by JoinType #205)
  • RangeDetacher::detach removes meaningless Result
  • fix: UnaryEvaluator & BinaryEvaluator handle the situation when the data is Null
  • fix: use an independent Binder when joining and the parent binder can extend context(from subquery join)
  • feat: add Mod for BinaryEvaluator

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould
feat: support more join case
7c0b71f 
- reconstruct the alias mechanism to ensure correctness during Join
- support Natural Join
- support multiple from(to Cross Join)
- when Using and Natural Join, the same columns are automatically removed (Fixme: JoinType needs to be supported to decide whether to use the columns of the left table or the right table)
- `RangeDetacher::detach` removes meaningless `Result`
@KKould KKould self-assigned this Apr 10, 2024
@KKould KKould added the enhancement New feature or request label Apr 10, 2024
@KKould
feat: support more join case
1e80977 
- fix: `UnaryEvaluator` & `BinaryEvaluator` handle the situation when the data is Null
- fix: use an independent Binder when joining and the parent binder can extend context(from subquery join)
- feat: add `Mod` for `BinaryEvaluator`
@KKould KKould linked an issue Apr 10, 2024 that may be closed by this pull request
Bug: wrong projection when joining the same table #203
Closed
@KKould KKould added the bug Something isn't working label Apr 10, 2024
@KKould KKould merged commit eac3ae8 into KipData:main Apr 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KKould KKould

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: wrong projection when joining the same table
1 participant
@KKould