Skip to content

feat/Refactor reimplement referenced columns & has table ref column & has agg call using visitor #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Howard2725
Copy link
Contributor

What problem does this PR solve?

solving the issue#273
Refactor: reimplement referenced_columns & has_table_ref_column & has_agg_call using Visitor #273

Add corresponding issue link with summary if exists -->

Issue link:

What is changed and how it works?

Code changes

  • [ v] Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • [v ] Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@Howard2725 Howard2725 changed the title Refactor reimplement referenced columns & has table ref column & has agg call using visitor feat/Refactor reimplement referenced columns & has table ref column & has agg call using visitor Jul 24, 2025
struct TableRefChecker {
found: bool,
}
impl<'a> Visitor<'a> for TableRefChecker {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fn visit(&mut self, expr: &'a ScalarExpression) -> Result<(), DatabaseError> {
    if self.found {
        return Ok(());
    }
    walk_expr(self, expr)
}

@KKould KKould requested a review from wszhdshys July 25, 2025 08:50
@KKould KKould added the good first issue Good for newcomers label Jul 25, 2025
@KKould KKould merged commit 5410cb2 into KipData:main Jul 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants