Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS signing #842

Merged
merged 21 commits into from
Dec 17, 2024
Merged

MacOS signing #842

merged 21 commits into from
Dec 17, 2024

Conversation

maxkatz6
Copy link
Contributor

@maxkatz6 maxkatz6 commented Dec 15, 2024

Steps:

  • Minimal sign scripts, figuring out how to use Cake.
  • Update AppVeyor to run mac build on MacOS machine. This will automatically solve "chmod +x" problem too.
  • Use p12 and password from the secrets/env.
  • Validate that signing actually works
  • Try writing notarizing script (it might timeout on CI with JIT entitlements)

Optional, to be done in other PRs:

  • Use NativeAOT in the release builds, remove JIT entitlements, try notarizing again
  • Create DMG file

Closes #686

@maxkatz6 maxkatz6 marked this pull request as draft December 15, 2024 02:27
@maxkatz6

This comment was marked as outdated.

@maxkatz6
Copy link
Contributor Author

Ah, okay, it runs now, after I double checked syntax with https://ci.appveyor.com/tools/validate-yaml
Weirdly it didn't tell any errors on commit status.

@maxkatz6

This comment was marked as outdated.

@maxkatz6 maxkatz6 marked this pull request as ready for review December 17, 2024 23:30
@KirillOsenkov KirillOsenkov merged commit 60c26a2 into KirillOsenkov:main Dec 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please sign and notarize macOS app
2 participants