Add option to preserve relative folder structure between .sln files #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnm2
commented
Apr 18, 2021
src/HtmlGenerator/Program.cs
Outdated
Comment on lines
339
to
343
| var relativePath = Paths.MakeRelativeToFolder(Path.GetDirectoryName(path), rootPath); | ||
| var segments = relativePath.Split(new[] { Path.DirectorySeparatorChar, Path.AltDirectorySeparatorChar }, StringSplitOptions.RemoveEmptyEntries); | ||
|
|
||
| foreach (var segment in segments) | ||
| solutionFolder = solutionFolder.GetOrCreateFolder(segment); |
There was a problem hiding this comment.
This is about as simple as I can imagine it being. Nice design!
jnm2
force-pushed
the
relative_sln_folders
branch
from
53c2c83 to
d1b4801
Compare
KirillOsenkov
approved these changes
Apr 18, 2021
|
Looks good. Let me know when it's ready and I'll push the button. |
|
Fantastic, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #159
Passing
/root:"C:\Users\Joseph\Source\Repos":As a test, passing
/root:"C:\Users\Joseph\Source":