fix: default project directory live updates when changed in /home or /home/settings paths.#10271
Open
fix: default project directory live updates when changed in /home or /home/settings paths.#10271
/home or /home/settings paths.#10271Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
nadr0
changed the title
/home or /home/settings paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #10270
issue
We do not trigger the upload loop to refresh the user's project directory when the settings modal is opened.
implementation
The code in the react provider that listens to the change runs the business logic! It only runs the business logic to update the directories on the home page. Now it works on the
/home/settingspage.When we implemented
PATHSin the code base we can nest paths together to have a page that renders/homeit could render/settingsor we can embed them in one another.I've updated the logic to accept
/homeand/home/settingsand it just works.commentary
This is correct business logic because our settings modal does not have a temporary/save state. When the user changes the value of a setting it is immediately written to
settings.toml. They do not need to confirm anything.