Wire hideSeams to Extrude P&C and respect all boolean optional args#10384
Wire hideSeams to Extrude P&C and respect all boolean optional args#10384max-mrgrsk merged 10 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
max-mrgrsk
left a comment
There was a problem hiding this comment.
In this pr:
hideSeamsdefaults toonin kcl
In follow up or this:
edit extrude featurechanges the reference
Bugs observed:
- sketch line is white on the white background
- extrude face with arc segment breaks engine
sketch001 = startSketchOn(XY)
profile001 = startProfile(sketch001, at = [-3.8, 4.39])
|> xLine(length = 8.24, tag = $seg01)
|> line(end = [-3.58, -5.04])
|> close()
extrude001 = extrude(profile001, length = 5, tagEnd = $capEnd001)
extrude002 = extrude(capEnd001, length = 5)
extrude003 = extrude(seg01, length = 5)hideSeams.mp4
|
Following @max-mrgrsk's review, we're now making sure that all boolean values in codemods are respected, even if set to false which would previously make them automatically ignored. So the diff is a little longer. Let me know when you can check the behavior again @max-mrgrsk! |
There was a problem hiding this comment.
@pierremtb I've disabled the auto merge so you can decide on including the fix in this PR or the follow-up. Otherwise gtg!
ZDS bugs:
- can not edit the wall face extrusion
- can not extrude the wall of the face extrusion
@gserena01 you might be interested in the engine bugs:
- any hideSeams make engine sad if the wall of triangular body is extruded
- engine is always unhappy on extruding the wall face of the extruded cap face
sketch001 = startSketchOn(XY)
profile001 = startProfile(sketch001, at = [-4.16, -2.97])
|> line(end = [2.31, 8.45])
|> line(end = [7.53, -7.02])
|> line(endAbsolute = [profileStartX(%), profileStartY(%)], tag = $seg01)
|> close()
extrude001 = extrude(profile001, length = 5, tagEnd = $capEnd001)
// extrude002 = extrude(profile001, length = 5, hideSeams = true) //zds bug on edit
// extrude002 = extrude(seg01, length = 5, hideSeams = true) //engine bug
extrude002 = extrude(capEnd001, length = 5, hideSeams = false)
// extrude002 = extrude(seg01, length = 5, hideSeams = true) // engine bug
// extrude002 = extrude(seg01, length = 5) // engine bug
// primitive face bugbugs.bugs.bugs.mp4
|
Thanks @max-mrgrsk! I'll see if I can quickly fix your first bullet I created #10424 for your second under the selectability initiative, I agree this is better separated from here. |
Context https://kittycadworkspace.slack.com/archives/C04KFV6NKL0/p1773157078998239
Update: following @max-mrgrsk's review, we're now making sure that all boolean values in codemods are respected, even if set to false which would previously make them automatically ignored. So the diff is a little longer.