Skip to content

Wire hideSeams to Extrude P&C and respect all boolean optional args#10384

Merged
max-mrgrsk merged 10 commits intomainfrom
pierremtb/adhoc/extrude-hide-seams-p-c
Mar 12, 2026
Merged

Wire hideSeams to Extrude P&C and respect all boolean optional args#10384
max-mrgrsk merged 10 commits intomainfrom
pierremtb/adhoc/extrude-hide-seams-p-c

Conversation

@pierremtb
Copy link
Contributor

@pierremtb pierremtb commented Mar 10, 2026

Context https://kittycadworkspace.slack.com/archives/C04KFV6NKL0/p1773157078998239

Update: following @max-mrgrsk's review, we're now making sure that all boolean values in codemods are respected, even if set to false which would previously make them automatically ignored. So the diff is a little longer.

@pierremtb pierremtb requested a review from a team as a code owner March 10, 2026 19:50
@vercel
Copy link

vercel bot commented Mar 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
modeling-app Ready Ready Preview, Comment Mar 12, 2026 7:44pm

Request Review

Copy link
Contributor

@max-mrgrsk max-mrgrsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this pr:

  • hideSeams defaults to on in kcl

In follow up or this:

  • edit extrude feature changes the reference

Bugs observed:

  • sketch line is white on the white background
  • extrude face with arc segment breaks engine
sketch001 = startSketchOn(XY)
profile001 = startProfile(sketch001, at = [-3.8, 4.39])
  |> xLine(length = 8.24, tag = $seg01)
  |> line(end = [-3.58, -5.04])
  |> close()
extrude001 = extrude(profile001, length = 5, tagEnd = $capEnd001)
extrude002 = extrude(capEnd001, length = 5)

extrude003 = extrude(seg01, length = 5)
hideSeams.mp4

@pierremtb pierremtb changed the title Wire hideSeams to Extrude P&C Wire hideSeams to Extrude P&C and respect all boolean optional args Mar 11, 2026
@pierremtb pierremtb requested a review from max-mrgrsk March 11, 2026 22:09
@pierremtb
Copy link
Contributor Author

Following @max-mrgrsk's review, we're now making sure that all boolean values in codemods are respected, even if set to false which would previously make them automatically ignored. So the diff is a little longer.

Let me know when you can check the behavior again @max-mrgrsk!

@max-mrgrsk max-mrgrsk disabled auto-merge March 12, 2026 16:36
Copy link
Contributor

@max-mrgrsk max-mrgrsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pierremtb I've disabled the auto merge so you can decide on including the fix in this PR or the follow-up. Otherwise gtg!

ZDS bugs:

  • can not edit the wall face extrusion
  • can not extrude the wall of the face extrusion

@gserena01 you might be interested in the engine bugs:

  • any hideSeams make engine sad if the wall of triangular body is extruded
  • engine is always unhappy on extruding the wall face of the extruded cap face
sketch001 = startSketchOn(XY)
profile001 = startProfile(sketch001, at = [-4.16, -2.97])
  |> line(end = [2.31, 8.45])
  |> line(end = [7.53, -7.02])
  |> line(endAbsolute = [profileStartX(%), profileStartY(%)], tag = $seg01)
  |> close()
extrude001 = extrude(profile001, length = 5, tagEnd = $capEnd001)
// extrude002 = extrude(profile001, length = 5, hideSeams = true) //zds bug on edit
// extrude002 = extrude(seg01, length = 5, hideSeams = true) //engine bug
extrude002 = extrude(capEnd001, length = 5, hideSeams = false)
// extrude002 = extrude(seg01, length = 5, hideSeams = true) // engine bug
// extrude002 = extrude(seg01, length = 5) // engine bug
// primitive face bug
bugs.bugs.bugs.mp4

@pierremtb
Copy link
Contributor Author

Thanks @max-mrgrsk! I'll see if I can quickly fix your first bullet

I created #10424 for your second under the selectability initiative, I agree this is better separated from here.

@max-mrgrsk max-mrgrsk merged commit bf4d82d into main Mar 12, 2026
59 checks passed
@max-mrgrsk max-mrgrsk deleted the pierremtb/adhoc/extrude-hide-seams-p-c branch March 12, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants