P&C integration of sketch block segments for surface modeling#10398
Draft
pierremtb wants to merge 40 commits intoachalmers/10386-surface-extrude-openfrom
Draft
P&C integration of sketch block segments for surface modeling#10398pierremtb wants to merge 40 commits intoachalmers/10386-surface-extrude-openfrom
pierremtb wants to merge 40 commits intoachalmers/10386-surface-extrude-openfrom
Conversation
…declares-a-variable
Asked Codex to take a stab at it. Got me to an engine error https://github.com/KittyCAD/engine/blob/903c4bc8593c244e964b6d88cfee70b2eec86fb3/cpp/endpoints/endpoints.cpp#L2262-L2263 ``` @settings(experimentalFeatures = allow) sketch001 = sketch(on = XY) { line1 = line(start = [var -4.78mm, var 4.81mm], end = [var 0.02mm, var -6.18mm]) line2 = line(start = [var 0.02mm, var -6.18mm], end = [var 8.97mm, var -2.05mm]) coincident([line1.end, line2.start]) line3 = line(start = [var 8.97mm, var -2.05mm], end = [var 8.97mm, var -2.05mm]) coincident([line2.end, line3.start]) line4 = line(start = [var -3.49mm, var 12.97mm], end = [var 9.41mm, var 15.64mm]) line5 = line(start = [var 9.41mm, var 15.64mm], end = [var 9.41mm, var 15.64mm]) coincident([line4.end, line5.start]) } extrude001 = extrude([sketch001.line1, sketch001.line2], length = 5, bodyType = SURFACE) ```
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Merging this PR will improve performance by 14.02%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | recast_medium_sketch |
200.7 µs | 176.1 µs | +14.02% |
Comparing pierremtb/issue10386-experiment (aa457b5) with achalmers/10386-surface-extrude-open (0644f4c)
Footnotes
-
93 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Base automatically changed from
pierremtb/issue10379-Make-sure-Start-Sketch-declares-a-variable
to
main
March 11, 2026 18:58
pierremtb
changed the title
pierremtb
changed the base branch from
main
to
achalmers/10386-surface-extrude-open
…sue10386-experiment
adamchalmers
force-pushed
the
achalmers/10386-surface-extrude-open
branch
from
35cdb04 to
014b05a
Compare
…sue10386-experiment
adamchalmers
force-pushed
the
achalmers/10386-surface-extrude-open
branch
from
85553c3 to
52713c2
Compare
…sue10386-experiment
…sue10386-experiment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #10413