Pull through alternative API base URL when present#10404
Open
lee-at-zoo-corp wants to merge 2 commits intomainfrom
Open
Pull through alternative API base URL when present#10404lee-at-zoo-corp wants to merge 2 commits intomainfrom
lee-at-zoo-corp wants to merge 2 commits intomainfrom
Conversation
|
Deployment failed with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
|
|
||
| export function generateDomainsFromBaseDomain(baseDomain: string) { | ||
| export function generateDomainsFromBaseDomain(baseDomain: string | undefined) { | ||
| const normalizedBaseDomain = baseDomain ?? '' |
Contributor
There was a problem hiding this comment.
What is meant by "normalized" here? If possible, I think this function should continue to accept a string and it should be on the caller to provide one.
Contributor
Author
There was a problem hiding this comment.
All the call sites will have to change, that's a lot vs 1 place.
normalize is very clear: going from string | undefined to string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents running
modeling-appwithapi.