Skip to content

Conversation

@jtran
Copy link
Contributor

@jtran jtran commented Nov 14, 2025

Fixes #8616.

When we do CSG inside the stdlib, the pathToNode of the artifacts point to the stdlib source. This branch changes it so that it points to the user's code that calls the stdlib.

Notice that near the bottom of rust/kcl-lib/tests/holes_cube/artifact_graph_flowchart.snap.md, the subtract changes from pointing to module 15 to module 0, and it now has a NodePath.

This should also change the pathToNode of Operations, but since we filter out operations that are internal to the stdlib, they don't appear in any output.

@vercel
Copy link

vercel bot commented Nov 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
modeling-app Ready Ready Preview Comment Nov 18, 2025 4:30pm

@jtran jtran force-pushed the jtran/ops-stdlib-entry-point branch from 0c3c3f5 to 1fe6832 Compare November 14, 2025 17:23
@jtran jtran changed the title Change stdlib Operations to point to the entry-point into the stdlib Change stdlib artifacts to point to the entry-point into the stdlib Nov 14, 2025
@jtran jtran force-pushed the jtran/ops-stdlib-entry-point branch from 1fe6832 to 346d776 Compare November 14, 2025 17:28
@jtran jtran marked this pull request as ready for review November 14, 2025 18:03
@jtran jtran requested a review from a team as a code owner November 14, 2025 18:03
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 14, 2025

CodSpeed Performance Report

Merging #8914 will not alter performance

Comparing jtran/ops-stdlib-entry-point (33af41c) with main (076725d)1

Summary

✅ 142 untouched
⏩ 92 skipped2

Footnotes

  1. No successful run was found on main (f937cb4) during the generation of this report, so 076725d was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 92 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Empty nodePath and pathToNode on subtract artifact coming from hole::hole

3 participants