-
Notifications
You must be signed in to change notification settings - Fork 90
Change stdlib artifacts to point to the entry-point into the stdlib #8914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
c050bb9 to
0c3c3f5
Compare
0c3c3f5 to
1fe6832
Compare
1fe6832 to
346d776
Compare
CodSpeed Performance ReportMerging #8914 will not alter performanceComparing Summary
Footnotes
|
Fixes #8616.
When we do CSG inside the stdlib, the pathToNode of the artifacts point to the stdlib source. This branch changes it so that it points to the user's code that calls the stdlib.
Notice that near the bottom of
rust/kcl-lib/tests/holes_cube/artifact_graph_flowchart.snap.md, the subtract changes from pointing to module 15 to module 0, and it now has a NodePath.This should also change the pathToNode of Operations, but since we filter out operations that are internal to the stdlib, they don't appear in any output.