-
Notifications
You must be signed in to change notification settings - Fork 90
Custom syntax highlighting theme #8943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
The unit tests are failing because I tried to wrap the unlabeled argument in KCL with a named grammar so I could somehow highlight it differently than labelled arguments, but I didn't find a way to do that at the end of the pipeline. I can remove that change if no one has ideas on how to get that highlighting to work, or if you think it's not worth trying to highlight them differently anyway. |
|
You need to update the unit tests. I'm guessing the ones in this file, |
|
Can do @jtran and @adamchalmers! |
|
@jtran I opted to just drop my |
|
@adamchalmers how is this feeling now? I dropped the chroma and the lightness a bit.
|
|
I did break that E2E test, I'll debug in the AM |


We've been using the default syntax highlighting theme in light mode and the "oneDark" syntax highlighting theme in dark mode for a long time, and I've got some qualms with them:
Light mode
Dark mode
Over the weekend I tried out a first pass at a replacement light and dark theme. I'm not sold on my approach but I want to get it out to the team to give their feedback and adjustments, because now I should be able to make changes very easily.
Light
Before
After
Dark
Before
After