Skip to content

Comments

Remove a lot of pop().unwrap()#8969

Merged
jtran merged 2 commits intomainfrom
jtran/remove-pop-unwrap
Nov 19, 2025
Merged

Remove a lot of pop().unwrap()#8969
jtran merged 2 commits intomainfrom
jtran/remove-pop-unwrap

Conversation

@jtran
Copy link
Contributor

@jtran jtran commented Nov 19, 2025

We have some work to do before we can lint against unwrap().

@jtran jtran requested a review from a team as a code owner November 19, 2025 04:24
@vercel
Copy link

vercel bot commented Nov 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
modeling-app Ready Ready Preview Comment Nov 19, 2025 5:19pm

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 19, 2025

CodSpeed Performance Report

Merging #8969 will not alter performance

Comparing jtran/remove-pop-unwrap (8f104de) with main (75133fd)

Summary

✅ 143 untouched
⏩ 92 skipped1

Footnotes

  1. 92 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@jtran jtran enabled auto-merge (squash) November 19, 2025 17:27
@jtran jtran merged commit 8037fd2 into main Nov 19, 2025
80 of 84 checks passed
@jtran jtran deleted the jtran/remove-pop-unwrap branch November 19, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants