Skip to content

Commit

Permalink
Fixed incorrect tabindex value for dialog title in documentation
Browse files Browse the repository at this point in the history
  • Loading branch information
KittyGiraudel committed Aug 6, 2017
1 parent 40d4ff1 commit 397f3c2
Showing 1 changed file with 11 additions and 12 deletions.
23 changes: 11 additions & 12 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,18 +67,6 @@ Here is the basic markup, which can be enhanced. Pay extra attention to the comm
-->
<div role="dialog" aria-labelledby="dialog-title">
<div role="document">
<!--
Dialog title related notes:
- It should have a different content than `Dialog Title`.
- It can have a different id than `dialog-title`.
- It does not have to have the `tabindex="0"` attribute however it is recommended so the dialog doesn’t jump directly to a field, displaying keyboard on mobiles.
-->
<h1 id="dialog-title" tabindex="0">Dialog Title</h1>

<!--
Here lives the main content of the dialog.
-->

<!--
Closing button related notes:
- It does have to have the `type="button"` attribute.
Expand All @@ -88,6 +76,17 @@ Here is the basic markup, which can be enhanced. Pay extra attention to the comm
<button type="button" data-a11y-dialog-hide aria-label="Close this dialog window">
&times;
</button>

<!--
Dialog title related notes:
- It should have a different content than `Dialog Title`.
- It can have a different id than `dialog-title`.
-->
<h1 id="dialog-title">Dialog Title</h1>

<!--
Here lives the main content of the dialog.
-->
</div>
</div>
</div>
Expand Down

0 comments on commit 397f3c2

Please sign in to comment.