Merge pull request #75 from edenspiekermann/release/4.0.0

Release 4.0.0

README.md

@@ -170,15 +170,19 @@ If necessary, the `create()` method also accepts the `targets` containers (the o
 
 ## Events
 
-When shown, hidden and destroyed, the instance will emit certain events. It is possible to subscribe to these with the `on()` method which will receive the dialog DOM element, the [event target](https://developer.mozilla.org/en-US/docs/Web/API/Event/target) (if any) and the [event current target](https://developer.mozilla.org/en-US/docs/Web/API/Event/currentTarget) (if any).
+When shown, hidden and destroyed, the instance will emit certain events. It is possible to subscribe to these with the `on()` method which will receive the dialog DOM element and the [event object](https://developer.mozilla.org/en-US/docs/Web/API/Event) (if any).
+
+The event object can be used to know which trigger (opener / closer) has been used in case of a `show` or `hide` event.
 
 ```javascript
-dialog.on('show', function (dialogEl, target, currentTarget) {
+dialog.on('show', function (dialogEl, event) {
   // Do something when dialog gets shown
+  // Note: opener is `event.currentTarget`
 });
 
-dialog.on('hide', function (dialogEl, target, currentTarget) {
+dialog.on('hide', function (dialogEl, event) {
   // Do something when dialog gets hidden
+  // Note: closer is `event.currentTarget`
 });
 
 dialog.on('destroy', function (dialogEl) {

a11y-dialog.js

@@ -227,20 +227,17 @@
 
   /**
    * Iterate over all registered handlers for given type and call them all with
-   * the dialog element as first argument, event target as second argument, if
-   * any, actual trigger (opener / closer) as third argument, if any.
+   * the dialog element as first argument, event as second argument (if any).
    *
    * @access private
    * @param {string} type
    * @param {Event} event
    */
   A11yDialog.prototype._fire = function (type, event) {
     var listeners = this._listeners[type] || [];
-    var target = event ? event.target : void 0;
-    var currentTarget = event ? event.currentTarget : void 0;
 
     listeners.forEach(function (listener) {
-      listener(this.node, target, currentTarget);
+      listener(this.node, event);
     }.bind(this));
   };
 

example/main.js

@@ -227,20 +227,17 @@
 
   /**
    * Iterate over all registered handlers for given type and call them all with
-   * the dialog element as first argument, event target as second argument, if
-   * any, actual trigger (opener / closer) as third argument, if any.
+   * the dialog element as first argument, event as second argument (if any).
    *
    * @access private
    * @param {string} type
    * @param {Event} event
    */
   A11yDialog.prototype._fire = function (type, event) {
     var listeners = this._listeners[type] || [];
-    var target = event ? event.target : void 0;
-    var currentTarget = event ? event.currentTarget : void 0;
 
     listeners.forEach(function (listener) {
-      listener(this.node, target, currentTarget);
+      listener(this.node, event);
     }.bind(this));
   };
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "a11y-dialog",
-  "version": "3.1.0",
+  "version": "4.0.0",
   "description": "A tiny script to make dialog windows accessible to assistive technology users.",
   "homepage": "https://github.com/edenspiekermann/a11y-dialog",
   "main": "a11y-dialog.js",