Make sure not to cause errors on the server

KittyGiraudel · Jun 28, 2018 · d2414c6 · d2414c6
1 parent 6c13ef9
commit d2414c6
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 7 deletions.
diff --git a/a11y-dialog.js b/a11y-dialog.js
@@ -18,7 +18,6 @@
   ];
   var TAB_KEY = 9;
   var ESCAPE_KEY = 27;
-  var isDialogSupported = 'show' in document.createElement('dialog');
   var focusedBeforeDialog;
 
   /**
@@ -39,7 +38,10 @@
     // Keep a reference of the node and the actual dialog on the instance
     this.container = node;
     this.dialog = node.querySelector('dialog, [role="dialog"]');
-    this.useDialog = isDialogSupported && this.dialog.nodeName === 'DIALOG';
+    this.useDialog = (
+      'show' in document.createElement('dialog') &&
+      this.dialog.nodeName === 'DIALOG'
+    );
 
     // Keep an object of listener types mapped to callback functions
     this._listeners = {};

diff --git a/a11y-dialog.min.js b/a11y-dialog.min.js
diff --git a/example/main.js b/example/main.js
@@ -18,7 +18,6 @@
   ];
   var TAB_KEY = 9;
   var ESCAPE_KEY = 27;
-  var isDialogSupported = 'show' in document.createElement('dialog');
   var focusedBeforeDialog;
 
   /**
@@ -39,7 +38,10 @@
     // Keep a reference of the node and the actual dialog on the instance
     this.container = node;
     this.dialog = node.querySelector('dialog, [role="dialog"]');
-    this.useDialog = isDialogSupported && this.dialog.nodeName === 'DIALOG';
+    this.useDialog = (
+      'show' in document.createElement('dialog') &&
+      this.dialog.nodeName === 'DIALOG'
+    );
 
     // Keep an object of listener types mapped to callback functions
     this._listeners = {};

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "a11y-dialog",
-  "version": "5.1.1",
+  "version": "5.1.2",
   "description":
     "A tiny script to make dialog windows accessible to assistive technology users.",
   "homepage": "https://github.com/edenspiekermann/a11y-dialog",