Skip to content

feat(segments): add segment locking with paint protection #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 11, 2025

Conversation

TomTonroe
Copy link
Contributor

Adds lock/unlock buttons to individual segments to prevent them from accidental modification when painting other segments.

image

Copy link

netlify bot commented Jul 3, 2025

Deploy Preview for volview-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0a40ce4
🔍 Latest deploy log https://app.netlify.com/projects/volview-dev/deploys/686d3e2201f1c90008d5cf3d
😎 Deploy Preview https://deploy-preview-760--volview-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Collaborator

@PaulHax PaulHax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really awesome addition!

Would you be up for making this lock feature work for the processing options (fill between and smooth)?

@TomTonroe
Copy link
Contributor Author

Thanks for the feedback!

I have updated startProcess to check if the active segment is locked before processing, and added a check in doPaintStroke.

@PaulHax PaulHax self-requested a review July 8, 2025 15:53
Copy link
Collaborator

@PaulHax PaulHax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I added another commit with more spacing between the toggle viz/lock buttons and ran npm run prettify

@PaulHax PaulHax requested a review from floryst July 8, 2025 15:55
Copy link
Collaborator

@floryst floryst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feature addition!

@floryst floryst added this pull request to the merge queue Jul 11, 2025
Merged via the queue into Kitware:main with commit 8d5ada4 Jul 11, 2025
7 checks passed
@TomTonroe TomTonroe deleted the segment-locking branch July 13, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants