-
Notifications
You must be signed in to change notification settings - Fork 75
feat(segments): add segment locking with paint protection #760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for volview-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really awesome addition!
Would you be up for making this lock feature work for the processing options (fill between and smooth)?
Thanks for the feedback! I have updated startProcess to check if the active segment is locked before processing, and added a check in doPaintStroke. |
Also ran `npm run prettify`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I added another commit with more spacing between the toggle viz/lock buttons and ran npm run prettify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feature addition!
Adds lock/unlock buttons to individual segments to prevent them from accidental modification when painting other segments.