Fix sorting on scores #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulHax
force-pushed
the
sort-fix
branch
3 times, most recently
from
fc57b5a to
eb7993b
Compare
PaulHax
force-pushed
the
sort-fix
branch
5 times, most recently
from
4cb801e to
38fcae7
Compare
PaulHax
force-pushed
the
sort-fix
branch
3 times, most recently
from
7fc0dc1 to
f510969
Compare
PaulHax
force-pushed
the
sort-fix
branch
2 times, most recently
from
e224a44 to
e326e4e
Compare
PaulHax
changed the title
PaulHax
force-pushed
the
sort-fix
branch
3 times, most recently
from
3e5fa3c to
3110baa
Compare
alesgenova
approved these changes
Jan 21, 2025
src/nrtk_explorer/app/transforms.py
Outdated
| logger = logging.getLogger(__name__) | ||
| logger.setLevel(logging.INFO) | ||
|
|
||
|
|
||
| class LazyDict(Mapping): |
There was a problem hiding this comment.
Nice utility!
According to this Mapping is for a read-only maps, and MutableMapping is used for mutable maps. Also an implementation for __delitem__() is missing.
| payload = msg.get("payload", {}) | ||
| logger.debug(f"Worker: Received {command} with ID {req_id}") | ||
|
|
||
| if command == "SET_MODEL": |
There was a problem hiding this comment.
I think we should place these command strings in some constant/enum, since we refer to them in different parts of the application.
There was a problem hiding this comment.
Sounds good. Let me do that in another PR right now, as I've made a mess of the history and modifed this file in the following PRs.
Rathern than through member variable
If the NUM_IMAGES_DEFAULT was smaller than current num_images, then we would clamp num_images when switching datasets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating the images visible in the image list, all other selected images are updated and their scores computed.
After images are scored, the table sort may have changed the images that are visible, so ImageList is asked to send visible image IDs again, which may trigger a new
_update_all_imagesif the set of images in view has changed.transformers.pipelineis not async, so we run that in subprocess viamultiprocess_predictor.py