fix(embeddings): save embeddings params on compute #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulHax
force-pushed
the
embedding-fix
branch
2 times, most recently
from
4eb4cf1 to
dee044e
Compare
This was
linked to
issues
Jan 20, 2025
PaulHax
force-pushed
the
embedding-fix
branch
from
f002578 to
c6e3a89
Compare
alesgenova
reviewed
Jan 21, 2025
| self.transformed_images.update(dataset_id_to_image) | ||
| self.emit_update() | ||
|
|
||
| @change("dataset_ids") |
There was a problem hiding this comment.
Just making a note, but don't change it in thie PR: I noticed that we have been using dataset_ids to store a list of image ids. I think we should change the name to make the intent less confusing
There was a problem hiding this comment.
Open to naming ideas. The totaly in my head convention was "dataset id"s mapped to a key in the COCO json, and "image ids" were keys for the original/transformed image on the state.
https://github.com/Kitware/nrtk-explorer/blob/main/src/nrtk_explorer/app/images/image_ids.py#L26-L29
PaulHax
force-pushed
the
embedding-fix
branch
from
c6e3a89 to
423f6f6
Compare
PaulHax
force-pushed
the
embedding-fix
branch
from
423f6f6 to
b96b9e2
Compare
PaulHax
force-pushed
the
embedding-fix
branch
from
b96b9e2 to
b568834
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and use saved params when ploting new transformed images.
Also, cache transformed images to re-plot then when embedding params are changed.
Closes #170
Closes #171