fix(plywriter): fix vtkPLYWriter normals

Also update the example and associated example image for the gallery
Kitware · Jan 15, 2024 · 4945167 · 4945167
1 parent 3d2ff18
commit 4945167
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/Documentation/content/docs/gallery/PLYWriterWithIcon.jpg b/Documentation/content/docs/gallery/PLYWriterWithIcon.jpg
diff --git a/Sources/IO/Geometry/PLYWriter/example/index.js b/Sources/IO/Geometry/PLYWriter/example/index.js
@@ -22,19 +22,19 @@ const reader = vtkPolyDataReader.newInstance();
 const writerReader = vtkPLYReader.newInstance();
 
 const writer = vtkPLYWriter.newInstance();
+writer.setInputConnection(reader.getOutputPort());
 reader
   .setUrl(`${__BASE_PATH__}/data/legacy/sphere.vtk`, { loadData: true })
   .then(() => {
-    writer.setInputData(reader.getOutputData());
-
     // writer.setTextureFileName('mytexture.jpg');
 
     const fileContents = writer.getOutputData();
+    writerReader.parseAsText(new TextEncoder().encode(fileContents));
     // Can also use a static function to write to PLY:
     // const fileContents = vtkPLYWriter.writePLY(reader.getOutputData());
+    // writerReader.parseAsArrayBuffer(fileContents.buffer);
 
     // Display the resulting PLY
-    writerReader.parseAsArrayBuffer(fileContents.buffer);
     renderer.resetCamera();
     renderWindow.render();
 

diff --git a/Sources/IO/Geometry/PLYWriter/index.js b/Sources/IO/Geometry/PLYWriter/index.js
@@ -361,9 +361,9 @@ function writePLY(
     }
 
     if (normals) {
-      nx = normals.getData()[i * 2];
-      ny = normals.getData()[i * 2 + 1];
-      nz = normals.getData()[i * 2 + 2];
+      nx = normals.getData()[i * 3];
+      ny = normals.getData()[i * 3 + 1];
+      nz = normals.getData()[i * 3 + 2];
     }
 
     writer.writeVertice(x, y, z, nx, ny, nz, u, v, r, g, b);