Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ImageMapper): label outlines with I/J slicing #3152

Merged
merged 3 commits into from
Nov 6, 2024
Merged

fix(ImageMapper): label outlines with I/J slicing #3152

merged 3 commits into from
Nov 6, 2024
+98 −27

Conversation

floryst
Copy link
Collaborator

@floryst floryst commented Oct 23, 2024 •
edited
Loading

Context

#3135

Results

Using setUseLabelOutline(true) with the ImageMapper will now work with the other slicing modes.

Changes

  • vtkImageMapper shader changed to support I/J slicing modes with label outline

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

I'll add tests later. Just wanted to get this out first.

@floryst floryst requested a review from finetjul October 23, 2024 19:59
@floryst floryst linked an issue Oct 23, 2024 that may be closed by this pull request
[Bug] Image Slice Label Map Outline Rendering with SlicingMode.I #3135
Closed
@PaulHax
Copy link
Collaborator

PaulHax commented Oct 23, 2024

This fixes outline rendering in VolView PR: Kitware/VolView#670

@finetjul
Copy link
Member

@sedghi

finetjul
finetjul approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I prefer @sedghi to review

sedghi
sedghi approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@sedghi sedghi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense, can we just make sure the original data also works now?

@floryst floryst added this pull request to the merge queue Oct 25, 2024
@floryst floryst removed this pull request from the merge queue due to a manual request Oct 25, 2024
@floryst
Copy link
Collaborator Author

floryst commented Oct 25, 2024

I think it makes sense, can we just make sure the original data also works now?

Which original data? The existing tests pass, and I'll adapt tests from @PaulHax for I and J slicing.

@floryst
Copy link
Collaborator Author

floryst commented Nov 4, 2024

I've added I+J slicing tests.

@floryst floryst added this pull request to the merge queue Nov 6, 2024
Merged via the queue into master with commit 3027990 Nov 6, 2024
3 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

🎉 This PR is included in version 32.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sedghi sedghi sedghi approved these changes

@finetjul finetjul finetjul approved these changes

Assignees
No one assigned
Labels
released Automated label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Image Slice Label Map Outline Rendering with SlicingMode.I
4 participants
@floryst @PaulHax @finetjul @sedghi