Skip to content

Actor2D scalar visibility #3277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 8, 2025
Merged

Actor2D scalar visibility #3277

merged 4 commits into from
Jul 8, 2025
+622 −68

Conversation

sankhesh
Copy link
Collaborator

@sankhesh sankhesh commented Jul 7, 2025

Add scalar based coloring support for Actor2D/Mapper2D

Results

Screenshot From 2025-07-07 18-53-01

In the above example,

  • the sphere is rendered using Mapper2D with cell scalars
  • the cone surface is rendered using Mapper2D with vtkProperty2D::setColor api
  • the cone wireframe is rendered using Mapper

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

@sankhesh sankhesh requested a review from floryst July 7, 2025 23:06
@sankhesh sankhesh force-pushed the actor2D_scalar_coloring branch from a9f8516 to 82b3746 Compare July 8, 2025 07:10
@BishopWolf BishopWolf mentioned this pull request Jul 8, 2025
Open
floryst
floryst reviewed Jul 8, 2025
View reviewed changes
Copy link
Collaborator

@floryst floryst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, overall LGTM! Just a question and a comment typo.

@sankhesh
style(mapper2d): removed unused imports, const fixes, lonely-if
611a509 
Fixed newly introduced formatting errors like unused import, const declaration, only if in an else
statement.
@sankhesh sankhesh force-pushed the actor2D_scalar_coloring branch from 82b3746 to 611a509 Compare July 8, 2025 17:01
@floryst floryst added this pull request to the merge queue Jul 8, 2025
Merged via the queue into Kitware:master with commit a85aea0 Jul 8, 2025
2 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2025

🎉 This PR is included in version 34.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Jul 8, 2025
@sankhesh sankhesh deleted the actor2D_scalar_coloring branch July 9, 2025 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryst floryst floryst left review comments

Assignees
No one assigned
Labels
released Automated label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sankhesh @floryst