Add a smart water heater switch with touch function of model TS0601_b… #10373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koenkk
force-pushed
the
master
branch
10 times, most recently
from
bf7848c to
da8e480
Compare
Koenkk
reviewed
Oct 16, 2025
| meta: { | ||
| tuyaDatapoints: [ | ||
| [1, "switch_1", tuya.valueConverter.onOff], | ||
| [21, "cur_current", tuya.valueConverterBasic.scale(0, 30000, 0, 30000)], |
Owner
There was a problem hiding this comment.
please remove the cur_ prefix for all
Koenkk
reviewed
Oct 16, 2025
| e.switch(), | ||
| e.enum("level", ea.STATE_SET, ["T0", "T30", "T60", "T90", "T120", "TON"]).withDescription("LEVEL"), | ||
| e.numeric("countdown", ea.STATE_SET).withValueMin(0).withValueMax(7200).withUnit("s").withDescription("countdown"), | ||
| e.numeric("cur_current", ea.STATE).withUnit("mA").withDescription("Current"), |
Owner
There was a problem hiding this comment.
Use, e.current(), e.voltage(), e.power() here. Make sure to correct the current divisor (tuya.valueConverterBasic.scale(0, 30000, 0, 30000)) accordingly (A is expected not mA)
Koenkk
reviewed
Oct 16, 2025
| extend: [tuya.modernExtend.tuyaBase({dp: true, forceTimeUpdates: true})], | ||
| exposes: [ | ||
| e.switch(), | ||
| e.enum("level", ea.STATE_SET, ["T0", "T30", "T60", "T90", "T120", "TON"]).withDescription("LEVEL"), |
Owner
There was a problem hiding this comment.
It's not quite clear to me what this does, could you extend the description?
Koenkk
reviewed
Oct 16, 2025
| ], | ||
| meta: { | ||
| tuyaDatapoints: [ | ||
| [1, "switch_1", tuya.valueConverter.onOff], |
Owner
There was a problem hiding this comment.
Suggested change
| [1, "switch_1", tuya.valueConverter.onOff], | |
| [1, "state", tuya.valueConverter.onOff], |
Otherwise I don't expect it works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…oiler_6
Link to picture pull request: TODO