Update eglo.ts #10550
Update eglo.ts #10550
Conversation
src/devices/eglo.ts
Outdated
| zigbeeModel: ["EZMB-RGB-TW-CLB"], | ||
| model: "EZMB-RGB-TW-CLB", | ||
| vendor: "AwoX", | ||
| description: "Automatically generated definition", |
There was a problem hiding this comment.
Could you add a proper description here?
src/devices/eglo.ts
Outdated
| vendor: "AwoX", | ||
| description: "Automatically generated definition", | ||
| extend: [ | ||
| m.deviceEndpoints({endpoints: {"1": 1, "3": 3}}), |
There was a problem hiding this comment.
Can you check if it also works without this?
There was a problem hiding this comment.
Sorry, i dont know how to check. This is my first step in Home Assistant and Zigbee :)
I followed exactly the instructions given to me by Zigbee2MQTT.
There was a problem hiding this comment.
Did you test code through e.g. an ext converter?
There was a problem hiding this comment.
i followed the instructions and created a external definition. And after that i created the pull request like the instruction says.
There was a problem hiding this comment.
Then in your external definition, can you check if it also works when removing m.deviceEndpoints({endpoints: {"1": 1, "3": 3}}),?
There was a problem hiding this comment.
I've added the external definitions code from the device in my config (without the part m.deviceEndpoints({endpoints: {"1": 1, "3": 3}}),)
and restarted zigbee2mqtt. After that i have a red sign that says "Device interview failed", but the device still shows up with all options e.g Brightness, color temp, effect, action etc.
There was a problem hiding this comment.
I don't expect that the red sign has to do with that, to fix it try to factory reset/re-pair the device. I think the line can be removed safely.
There was a problem hiding this comment.
You're right. The problem wasn't related to that. I re-paired the device and now the red sign is gone. :)
|
Could you also submit a picture for the docs (guide)? Make sure that the file name is |
|
done |
|
I jus noticed this device was already added in #10599, can you check if it works out of the box in z2m 2.6.3? |
No, if I delete my external support file and restart zigbee2mqtt, the device says : not supported: generated |
|
Ah true, it has only been added to the dev branch yet, can you check that?
|
2 participants
Link to picture pull request: TODO