fix: Bosch BTH-R*: Rename key to window_detection
#10722
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
To prevent another breaking change, I would suggest to add |
Contributor
Author
|
@Koenkk Sure, but a bit more has then to be changed as well. I can certainly do that if you prefer. However, reverting a key's name seemed like the less invasive option. 😊 |
Owner
|
hmm, then lets do the rename, could you update this pr to do just that? |
Contributor
Author
|
@Koenkk Alright, should be good to go. 😊 |
Owner
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #10309, the property key for the window detection switch was renamed from
window_detectiontowindow_open_modewhich isn't recognized by the HA extension. This PR fixes the issue.Depends on #10709