Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Migrate from eslint/prettier to Biome #8859

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: Migrate from eslint/prettier to Biome #8859

wants to merge 4 commits into from

Conversation

Koenkk
Copy link
Owner

@Koenkk Koenkk commented Feb 20, 2025

CC: @Nerivec

CI lint/format step went from 27 to 1 second! 😮


if (externalDefinitionsLookup.has(lookupModel)) {
return externalDefinitionsLookup.get(lookupModel);
}

return externalDefinitionsLookup.get(lookupModel.replace(/\0(.|\n)*$/g, '').trim());
return externalDefinitionsLookup.get(lookupModel.replace(/\0(.|\n)*$/g, "").trim());

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High

This
regular expression
that depends on
library input
may run slow on strings starting with '\u0000' and with many repetitions of '\u0000'.
This
regular expression
that depends on
library input
may run slow on strings starting with '\u0000' and with many repetitions of '\u0000'.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

مافام

@@ -218,7 +218,7 @@
return await getDefinitions(indexes);
}

indexes = MODELS_INDEX[lookupModel.replace(/\0(.|\n)*$/g, '').trim()];
indexes = MODELS_INDEX[lookupModel.replace(/\0(.|\n)*$/g, "").trim()];

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High

This
regular expression
that depends on
library input
may run slow on strings starting with '\u0000' and with many repetitions of '\u0000'.
This
regular expression
that depends on
library input
may run slow on strings starting with '\u0000' and with many repetitions of '\u0000'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants