Add Support for Enkin - ZDM150 Dimmer Module #8860
Open
+26
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
encryptix
commented
Feb 20, 2025
src/devices/enkin.js
Outdated
| extend: [light({powerOnBehavior: false, effect: false, configureReporting: true}), forcePowerSource({powerSource: 'Mains (single phase)'})], | ||
|
|
||
| configure: async (device, coordinatorEndpoint) => { | ||
| device.powerSource = 'Mains (single phase)'; |
There was a problem hiding this comment.
I don't know if this line is needed when its also on L10
encryptix
commented
Feb 20, 2025
src/devices/enkin.js
Outdated
| const endpoint = device.getEndpoint(1); | ||
| await bind(endpoint, coordinatorEndpoint, ['genOnOff', 'genLevelCtrl']); | ||
| await onOff(endpoint, {min: 0, max: 0xfffe}); | ||
|
|
There was a problem hiding this comment.
The module was not reporting if it was on or off or the adjusted brightness level if this was done via the physical switch.
encryptix
commented
Feb 20, 2025
src/devices/enkin.js
Outdated
| device.powerSource = 'Mains (single phase)'; | ||
|
|
||
| const endpoint = device.getEndpoint(1); | ||
| await bind(endpoint, coordinatorEndpoint, ['genOnOff', 'genLevelCtrl']); |
There was a problem hiding this comment.
I don't know what this line or the next line does, copied from other device files for lights.
Koenkk
reviewed
Feb 21, 2025
src/devices/enkin.js
Outdated
| description: '150W Dimmer Module', | ||
| extend: [light({powerOnBehavior: false, effect: false, configureReporting: true}), forcePowerSource({powerSource: 'Mains (single phase)'})], | ||
|
|
||
| configure: async (device, coordinatorEndpoint) => { |
There was a problem hiding this comment.
This shouldn't be needed as you have configureReporting: true
There was a problem hiding this comment.
I see modernExtend does the following automatically
await setupAttributes(device, coordinatorEndpoint, 'genOnOff', [{attribute: 'onOff', min: 'MIN', max: 'MAX', change: 1}]);
configureSetPowerSourceWhenUnknown('Mains (single phase)'),
Is it just these I remove? How do I keep configuration for genLevelCtrl ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://enkin.com/products/ss-en-00-zdm150-150w-led-zigbee-dimmer-module
This is an external converter I have for a dimmer module and is working well.