Skip to content

fix: Allow BuffaloZclDataType for AttributeDefinition.type #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Koenkk
Copy link
Owner

@Koenkk Koenkk commented Jul 31, 2025

Already allow for parameter and now also for the AttributeDefinition. Required for Koenkk/zigbee-herdsman-converters#9711

@Koenkk Koenkk requested a review from Nerivec July 31, 2025 18:18
@Nerivec
Copy link
Collaborator

Nerivec commented Jul 31, 2025

Need to change Attribute too.
It opens up the code paths a little, though I suppose it all ends up in BuffaloZcl read/write. Might want to add a test or two just in case though, make sure calls with both types are covered.

@Koenkk
Copy link
Owner Author

Koenkk commented Aug 4, 2025

Closing this PR as this won't work for reading (only writing), when reading the type is included in the ZCL payload.

@Koenkk Koenkk closed this Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants