Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump github.com/daveshanley/vacuum from 0.9.15 to 0.12.1 #1372

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 22, 2024

Bumps github.com/daveshanley/vacuum from 0.9.15 to 0.12.1.

Release notes

Sourced from github.com/daveshanley/vacuum's releases.

v0.12.1

Changelog

  • b4e7718 Update lint.go cmd documentation

v0.12.0

Before v0.12

All core functions returned the same path provided in the rule. This is because there was no way to determine the actual path due to limitations in some core dependencies.

This is explained here: #269 and was recently revived here: #527

After v0.12

All core functions now return the correct JSON path for all results. This is now possible because of two supporting library upgrades that we control has facilitated this possibility, without depending on any upstream libs we don't control.

For example, the following ruleset:

rules:
  description-is-coffee:
    description: "check that every description is 'coffee'"
    given: $..description
    severity: warn
    then:
      function: pattern
      functionOptions:
        match: "^coffee$"
  every-response-has-schema:
    description: "check that every media type for 200 response has a made up field called peanuts"
    given: $.paths.*.*.responses.200.content.*
    severity: error
    then:
      field: peanuts
      function: truthy

When run with the model/test_files/burgershop.openapi.yaml sample spec, results in output like this:

vacuum lint model/test_files/burgershop.openapi.yaml -r ruleset.yaml -d -m

Screenshot 2024-08-05 at 6 18 26 PM

However, now in v0.12+ the same command (and using the new --no-clip command) shows the actual path.

vacuum lint model/test_files/burgershop.openapi.yaml -r ruleset.yaml -d -m --no-clip

Screenshot 2024-08-05 at 6 20 34 PM

Changelog

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Aug 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.42%. Comparing base (e23136a) to head (9857e27).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1372      +/-   ##
==========================================
- Coverage   22.49%   22.42%   -0.07%     
==========================================
  Files          54       54              
  Lines        4517     4517              
==========================================
- Hits         1016     1013       -3     
- Misses       3402     3404       +2     
- Partials       99      100       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/daveshanley/vacuum-0.12.1 branch 4 times, most recently from df6c6b1 to 5cfebd3 Compare August 22, 2024 10:36
Bumps [github.com/daveshanley/vacuum](https://github.com/daveshanley/vacuum) from 0.9.15 to 0.12.1.
- [Release notes](https://github.com/daveshanley/vacuum/releases)
- [Changelog](https://github.com/daveshanley/vacuum/blob/main/.goreleaser.yaml)
- [Commits](daveshanley/vacuum@v0.9.15...v0.12.1)

---
updated-dependencies:
- dependency-name: github.com/daveshanley/vacuum
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@pmalek pmalek force-pushed the dependabot/go_modules/github.com/daveshanley/vacuum-0.12.1 branch from 5cfebd3 to 9857e27 Compare August 22, 2024 12:12
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 10, 2024

A newer version of github.com/daveshanley/vacuum exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant