fix: clarify validate konnect behaviors #1375
Open
+11
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Harris <[email protected]>
|
@johnharris85 Could you please check why the tests are not running for this particular PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few quick fixes around Konnect behavior:
gateway validatevsfile validatewas incorrect (said both would contact a running CP to validate,file validatedoes not do this,gateway validatedoes).konnectsection being missing has been changed to a warning (as you can specify konnect cli flags still, and it now returns a 0 exit code for automation purposes) and the message has been clarified.--konnect-compatibilityand--parallelismflags gated to their relevant parent commands (file validateandgateway validaterespectively).