Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Request Validator incorrectly refers to Kong format schema #8111

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lena-larionova
Copy link
Contributor

@lena-larionova lena-larionova commented Nov 1, 2024

Description

The doc says the the Kong format schema validation is supported, which is incorrect. JSON Schema format validation is actually what's supported.

Fixes https://konghq.atlassian.net/browse/FTI-6196.

Note to reviewers: I fixed the title of the section referring to the "Kong format schema" and some minor cleanup to the page, including removing unnecessary output examples.
However, I couldn't actually get these examples to work as documented in the example. The last step, validation, always fails for me- though this is probably out of scope of this PR and is a separate issue.

Testing instructions

Preview link:

Checklist

@lena-larionova lena-larionova added the review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly? label Nov 1, 2024
@lena-larionova lena-larionova requested a review from a team as a code owner November 1, 2024 22:03
Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for kongdocs ready!

Name Link
🔨 Latest commit 943e2ec
🔍 Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/6725502c0938720008040d08
😎 Deploy Preview https://deploy-preview-8111--kongdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
9 paths audited
Performance: 93 (🟢 up 2 from production)
Accessibility: 92 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 99 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:general Review for general accuracy and presentation. Does the doc work? Does it output correctly?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant