tests(clustering): fix 01-sync_spec.lua for incremental sync #13833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cherry-pick kong-ee
StarlightIbuki
commented
Nov 5, 2024
|
It did not fix 01-sync_spec.lua really, I thiink that we should have a full fix for it then close ticket. |
chronolaw
changed the title
chronolaw
requested changes
Nov 6, 2024
| @@ -802,7 +802,7 @@ skip_inc_sync("CP/DP labels #" .. strategy, function() | |||
| end) | |||
| end) | |||
|
|
|||
| skip_inc_sync("CP/DP cert details(cluster_mtls = shared) #" .. strategy, function() | |||
| pending_inc_sync("CP/DP cert details(cluster_mtls = shared) #" .. strategy, function() | |||
There was a problem hiding this comment.
We must fix it when enabling incremental sync
There was a problem hiding this comment.
This PR aims to keep an accurate status of the tests rather than making them a permanent state
There was a problem hiding this comment.
If you are not in favor of it please close it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes KAG-5551