-
Notifications
You must be signed in to change notification settings - Fork 5k
fix(ai): (FTI-6403) Fixed error with Azure path override formatting #14051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9c0c579
to
bedbcc7
Compare
oowl
reviewed
Dec 30, 2024
fffonion
reviewed
Jan 8, 2025
c9afd58
to
3391c06
Compare
RobSerafini
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backport Approved
fcad36a
to
008e80e
Compare
fffonion
approved these changes
Jan 17, 2025
oowl
approved these changes
Jan 17, 2025
…always return 404 Co-authored-by: Jack Tysoe <[email protected]>
008e80e
to
83f2f3f
Compare
…content type Co-authored-by: Jack Tysoe <[email protected]>
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport release/3.9.x
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
plugins/ai-proxy
plugins/ai-request-transformer
plugins/ai-response-transformer
size/L
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There was a bug found, where the Azure provider stopped parsing 'custom upstream path' overrides since Kong 3.9.0.
Every request would 404 due to incorrect parsing.
I've added a parser / config options test to prevent this from happening again!
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
FTI-6403
AG-191