-
Notifications
You must be signed in to change notification settings - Fork 4.9k
feat: expose kong.request.get_raw_path in pluginsocket #14338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding a test for the exposed API
@StarlightIbuki if I'm not wrong, the exposed API tests are under https://github.com/garciasdos/kong/blob/a077ebf12006b2b9f8e0c9b114f08c6bd31c41d2/t/01-pdk/04-request/20-get_raw_path.t right? I can't find dedicated test files that directly test the proto definitions |
We could add a test here: https://github.com/Kong/kong/blob/master/spec/02-integration/10-external-plugins/02-execution_spec.lua and https://github.com/Kong/kong/blob/master/spec/02-integration/10-external-plugins/02-execution_spec.lua |
@StarlightIbuki I added some tests here 587c6a7. Let me know if that's what you were expecting. Thanks! |
Great! Thanks for your contribution! |
I will bring more attention from people to see if we can get this merged |
Co-authored-by: Xumin <[email protected]>
- Implemented the retrieval of raw request paths in both Go and Python plugins. - Updated Go plugin to set the header "x-raw-path-from-go". - Updated Python plugin to set the header "x-raw-path-from-python". - Added integration tests to verify the correct behavior of raw path retrieval.
Summary
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference