Skip to content

feat: expose kong.request.get_raw_path in pluginsocket #14338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

garciasdos
Copy link

Summary

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

@CLAassistant
Copy link

CLAassistant commented Mar 3, 2025

CLA assistant check
All committers have signed the CLA.

@team-eng-enablement team-eng-enablement added the author/community PRs from the open-source community (not Kong Inc) label Mar 3, 2025
Copy link
Contributor

@StarlightIbuki StarlightIbuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a test for the exposed API

@StarlightIbuki StarlightIbuki self-requested a review June 16, 2025 07:03
@garciasdos
Copy link
Author

Consider adding a test for the exposed API

@StarlightIbuki if I'm not wrong, the exposed API tests are under https://github.com/garciasdos/kong/blob/a077ebf12006b2b9f8e0c9b114f08c6bd31c41d2/t/01-pdk/04-request/20-get_raw_path.t right? I can't find dedicated test files that directly test the proto definitions

@StarlightIbuki
Copy link
Contributor

Consider adding a test for the exposed API

@StarlightIbuki if I'm not wrong, the exposed API tests are under garciasdos/kong@a077ebf/t/01-pdk/04-request/20-get_raw_path.t right? I can't find dedicated test files that directly test the proto definitions

We could add a test here: https://github.com/Kong/kong/blob/master/spec/02-integration/10-external-plugins/02-execution_spec.lua and https://github.com/Kong/kong/blob/master/spec/02-integration/10-external-plugins/02-execution_spec.lua

@garciasdos
Copy link
Author

@StarlightIbuki I added some tests here 587c6a7. Let me know if that's what you were expecting. Thanks!

@StarlightIbuki
Copy link
Contributor

@StarlightIbuki I added some tests here 587c6a7. Let me know if that's what you were expecting. Thanks!

Great! Thanks for your contribution!

@StarlightIbuki
Copy link
Contributor

I will bring more attention from people to see if we can get this merged

garciasdos and others added 6 commits July 2, 2025 10:56
- Implemented the retrieval of raw request paths in both Go and Python plugins.
- Updated Go plugin to set the header "x-raw-path-from-go".
- Updated Python plugin to set the header "x-raw-path-from-python".
- Added integration tests to verify the correct behavior of raw path retrieval.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author/community PRs from the open-source community (not Kong Inc) size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants