Skip to content

fix(grpc): Fix error "proto3 disallow 'optional' label" #14426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(grpc): Fix error "proto3 disallow 'optional' label" #14426

wants to merge 1 commit into from
+2 −1

Conversation

yixinguo-ssc
Copy link

Summary

Fix Issue 14421
grpc-gateway fails to load proto file with message "proto3 disallow 'optional' label"

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[14421](#14421)

@CLAassistant
Copy link

CLAassistant commented Apr 18, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@team-eng-enablement team-eng-enablement added the author/community PRs from the open-source community (not Kong Inc) label Apr 18, 2025
@yixinguo-ssc
fix(grpc): Fix error "proto3 disallow 'optional' label"
a9d5628 
When grpc-gateway plugin loads a proto3 proto file with optional labeled fields, it will throw an error "proto3 disallow 'optional' label". This fixes the issue by enabling proto3_optional in protoc.
@yixinguo-ssc yixinguo-ssc mentioned this pull request Apr 30, 2025
Open
1 task
@chronolaw chronolaw requested a review from StarlightIbuki May 21, 2025 03:28
@StarlightIbuki
Copy link
Contributor

With 1 more approval I will add change log for this

Oyami-Srk
Oyami-Srk approved these changes Jun 5, 2025
View reviewed changes
Copy link
Member

@Oyami-Srk Oyami-Srk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oyami-Srk Oyami-Srk Oyami-Srk approved these changes

@StarlightIbuki StarlightIbuki StarlightIbuki approved these changes

Assignees
No one assigned
Labels
author/community PRs from the open-source community (not Kong Inc) size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

grpc-gateway fails to load proto file with message "proto3 disallow 'optional' label"
5 participants
@yixinguo-ssc @CLAassistant @StarlightIbuki @Oyami-Srk @team-eng-enablement