-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(admission): use Ignore
failure policy in tests (same as charts)
#5063
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5063 +/- ##
=======================================
+ Coverage 73.3% 75.6% +2.2%
=======================================
Files 167 167
Lines 18909 18911 +2
=======================================
+ Hits 13867 14299 +432
+ Misses 4218 3788 -430
Partials 824 824
☔ View full report in Codecov by Sentry. |
d677c33
to
178b999
Compare
Ignore
failure policy in tests (same as charts)
36dcaca
to
1132773
Compare
dc12bf7
to
19fc915
Compare
Ignore
failure policy in tests (same as charts)Ignore
failure policy in tests (same as charts)
19fc915
to
d6a692b
Compare
d6a692b
to
3e3c7cb
Compare
…#5063) (#5078) (cherry picked from commit a364f35) Co-authored-by: Grzegorz Burzyński <[email protected]>
What this PR does / why we need it:
Uses the same failure policy (
Ignore
) in the test admission webhook configuration as the one used in charts and deploy-admission-controller.sh script.The policy tells Kubernetes what to do in case status 500 is returned from the webhook:
Ignore
- accept the object.Fail
- do not accept the object.Given that we're using
Ignore
in production, we should use the same in tests. Without that, we may have test cases where we expect an object to be rejected, but we returned status 500, which in production would still accept the object.What validations will this bring back to life for installations using default
failurePolicy
:HTTPRoute
:KongConsumer
:Which issue this PR fixes:
Related issue: #4680
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR