Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add INFO log for admissions which aren't allowed #6086

Merged
merged 5 commits into from
Oct 12, 2024

Conversation

dweber019
Copy link
Contributor

What this PR does / why we need it:

It will add a INFO log message when an admission isn't allowed. This helps debugging and monitoring.

Which issue this PR fixes:

Fixes #6084

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@dweber019 dweber019 requested a review from a team as a code owner May 25, 2024 13:23
@dweber019 dweber019 force-pushed the feat/admission-log branch from 452af5e to e3bf5a4 Compare May 25, 2024 13:25
@dweber019
Copy link
Contributor Author

@pmalek related too #6087
Thx

Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, other than that 👍

internal/admission/handler.go Outdated Show resolved Hide resolved
@dweber019 dweber019 force-pushed the feat/admission-log branch from e3bf5a4 to 7893b49 Compare May 30, 2024 19:23
pmalek
pmalek previously approved these changes May 31, 2024
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

programmer04
programmer04 previously approved these changes Jun 7, 2024
@programmer04 programmer04 enabled auto-merge (squash) June 7, 2024 12:12
@CLAassistant
Copy link

CLAassistant commented Jun 27, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ dweber019
✅ programmer04
❌ lahabana
You have signed the CLA already but the status is still pending? Let us recheck it.

@programmer04 programmer04 added this to the KIC v3.3.x milestone Jul 10, 2024
@programmer04
Copy link
Member

@lahabana please sign CLA and we're good to go

@randmonkey randmonkey modified the milestones: KIC v3.3.x, KIC v3.4.x Aug 26, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.2%. Comparing base (811148a) to head (98db664).
Report is 7 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #6086   +/-   ##
=====================================
  Coverage   74.1%   74.2%           
=====================================
  Files        202     202           
  Lines      20492   20539   +47     
=====================================
+ Hits       15198   15244   +46     
- Misses      4274    4287   +13     
+ Partials    1020    1008   -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@programmer04 programmer04 merged commit 11008ef into Kong:main Oct 12, 2024
40 checks passed
@dweber019 dweber019 deleted the feat/admission-log branch October 13, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admission webhook observability
6 participants