chore: use generated ValidatingWebhookConfiguration in integration tests #6701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
programmer04
added
area/debt
area/tests
area/maintenance
programmer04
force-pushed
the
webhok-impr
branch
from
16fe2cb to
c68eca0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6701 +/- ##
======================================
Coverage ? 77.7%
======================================
Files ? 204
Lines ? 23896
Branches ? 0
======================================
Hits ? 18587
Misses ? 4361
Partials ? 948 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
czeslavo
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Nice 👍
What would you say about setting up the admission webhook globally in integration tests suite (without namespace filtering), not only in the *_webhook_test.go cases? It would satisfy the requirement for #4680 we have queued.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Everywhere in tests configuration rendered with Kustomize based on the content of
config/webhookdirectory is usedCloses #5660