Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] chore: refactor Konnect configuration synchronization #6764

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Dec 3, 2024

What this PR does / why we need it:

Which issue this PR fixes:

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@czeslavo czeslavo force-pushed the chore/refactor-konnect-admin-api-client branch from 966f2cc to 0a08ab9 Compare December 3, 2024 21:25
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 9.75610% with 111 lines in your changes missing coverage. Please review.

Project coverage is 60.8%. Comparing base (655e921) to head (082fa02).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/konnect/config_synchronizer.go 0.0% 76 Missing ⚠️
internal/adminapi/konnect.go 0.0% 14 Missing ⚠️
internal/dataplane/kongstate/credentials.go 0.0% 4 Missing ⚠️
internal/manager/run.go 33.3% 4 Missing ⚠️
internal/dataplane/deckgen/deckgen.go 40.0% 2 Missing and 1 partial ⚠️
internal/dataplane/kong_client.go 70.0% 3 Missing ⚠️
internal/manager/setup.go 0.0% 3 Missing ⚠️
internal/dataplane/kongstate/uuid.go 0.0% 2 Missing ⚠️
internal/dataplane/kongstate/license.go 0.0% 1 Missing ⚠️
internal/dataplane/kongstate/types.go 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #6764      +/-   ##
========================================
- Coverage   77.0%   60.8%   -16.2%     
========================================
  Files        211     211              
  Lines      25484   25506      +22     
========================================
- Hits       19623   15515    -4108     
- Misses      4847    8689    +3842     
- Partials    1014    1302     +288     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czeslavo czeslavo added the ci/run-e2e Trigger e2e test run from PR label Dec 4, 2024
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/12155124324

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Dec 4, 2024
@czeslavo czeslavo force-pushed the chore/refactor-konnect-admin-api-client branch from 0a08ab9 to df9bc23 Compare December 18, 2024 14:00
@czeslavo czeslavo force-pushed the chore/refactor-konnect-admin-api-client branch from df9bc23 to 082fa02 Compare December 18, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants