chore(v8bridge) minor fixes for v8bridge build #633
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These need to be fixed in order to produce a bump to
ngx_wasm_runtimes
.This puts us in an almost chicken-and-egg situation when bumping V8. We need to make a 3 (or rather 4) step process for bumping V8 if their build process changes:
ngx_wasm_module
ngx_wasm_runtimes
ngx_wasm_module
This time I've done things out-of-order by tweaking the repo by hand in the ARM VM to get step 2 done first, but then I realized that step 3 won't work without step 1 (this PR). Another PR with step 4 will then follow.
(Perhaps the build part of
util/runtimes/v8.sh
should instead live inngx_wasm_runtimes
, so that all steps for building a new V8 artifact lived there, and thenngx_wasm_module
could just treatngx_wasm_runtimes
as its V8 upstream, and in its ownutil/runtimes/v8.sh
, if a build from source is desired, it could fetch that repo and runmake
on it.)