Skip to content

fix(ops) free plan struct on ngx_wasm_ops_plan_destroy #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

thibaultcha
Copy link
Member

Fix #675

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.72299%. Comparing base (c2b0fb1) to head (b6050fa).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #678         +/-   ##
===================================================
+ Coverage   90.71817%   90.72299%   +0.00481%     
===================================================
  Files             54          54                 
  Lines          11571       11577          +6     
  Branches        1711        1712          +1     
===================================================
+ Hits           10497       10503          +6     
  Misses          1068        1068                 
  Partials           6           6                 
Files with missing lines Coverage Δ
src/wasm/ngx_wasm_ops.c 93.60902% <100.00000%> (+0.14748%) ⬆️
Flag Coverage Δ
unit-ngx_1.21.6-wasmer-no_ipc-ssl-debug-no_hup-static 89.26236% <0.00000%> (-0.04099%) ⬇️
unit-ngx_1.27.3-v8-no_ipc-ssl-debug-no_hup-static 89.60280% <0.00000%> (-0.04189%) ⬇️
unit-ngx_1.27.3-wasmer-no_ipc-no_ssl-no_debug-no_hup-static 86.38451% <0.00000%> (-0.04291%) ⬇️
unit-ngx_1.27.3-wasmer-no_ipc-ssl-debug-no_hup-static 89.30136% <0.00000%> (-0.04121%) ⬇️
unit-ngx_1.27.3-wasmer-no_ipc-ssl-no_debug-no_hup-static 86.74787% <0.00000%> (-0.04228%) ⬇️
unit-ngx_1.27.3-wasmtime-ipc-no_ssl-debug-no_hup-static 88.87971% <0.00000%> (-0.03019%) ⬇️
unit-ngx_1.27.3-wasmtime-no_ipc-no_ssl-debug-no_hup-static-wasm32-unknown-unknown 88.28829% <0.00000%> (-0.04188%) ⬇️
unit-ngx_1.27.3-wasmtime-no_ipc-ssl-debug-hup-dynamic 88.30973% <0.00000%> (-0.06426%) ⬇️
unit-ngx_1.27.3-wasmtime-no_ipc-ssl-debug-hup-static 88.28525% <0.00000%> (-0.06438%) ⬇️
unit-openresty_1.27.1.1-wasmtime-no_ipc-ssl-debug-no_hup-dynamic 90.68800% <100.00000%> (+0.00396%) ⬆️
unit-openresty_1.27.1.1-wasmtime-no_ipc-ssl-debug-no_hup-static 90.66809% <100.00000%> (+0.00399%) ⬆️
valgrind-ngx_1.27.3-v8---debug-no_hup-static 33.16639% <0.00000%> (-0.02216%) ⬇️
valgrind-ngx_1.27.3-wasmer---debug-hup-static 80.40682% <0.00000%> (-0.05309%) ⬇️
valgrind-ngx_1.27.3-wasmer---debug-no_hup-static 80.48378% <0.00000%> (-0.05314%) ⬇️
valgrind-ngx_1.27.3-wasmtime---debug-no_hup-static 33.50372% <0.00000%> (-0.02236%) ⬇️
valgrind-openresty_1.27.1.1-wasmer---debug-no_hup-static 61.54624% <100.00000%> (+0.02333%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@thibaultcha thibaultcha merged commit b507f3f into main Feb 5, 2025
30 checks passed
@thibaultcha thibaultcha deleted the fix/free-plan-struct branch February 5, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible memory leak on FFI call
1 participant