Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(analytics-config-check): testing single root node fix #1507

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mihai-peteu
Copy link
Contributor

Summary

Testing whether this fixes the Runtime directive used on component with non-element root node. The directives will not function as intended. seen in the analytics MFE when loading any page that contains the VitalsPaywall (which internally wraps its content in an AnalyticsConfigCheck component from public-ui)

Screenshot 2024-07-22 at 08 11 40

Resources

@kongponents-bot
Copy link
Collaborator

Preview components from this PR in consuming application

In consuming application project install preview versions of shared packages generated by this PR:

@kong-ui-public/analytics-config-store@pr-1507
@kong-ui-public/analytics-metric-provider@pr-1507
@kong-ui-public/dashboard-renderer@pr-1507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants