Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve query string normalization and add hooks system #114

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ad-git
Copy link

@ad-git ad-git commented Aug 12, 2016

  • Improve query string normalization to RFC 3986 and avoid truncation if query has duplicate parameter with same name.
  • Additional hook system useful for debug

@ahmadnassri
Copy link
Contributor

hey @ad-git sorry for missing this PR!!!

looks great, but can you please add some tests + update the documentation?

thank you.

@rolandow
Copy link

rolandow commented Apr 6, 2017

Does this also solve the problem when I am trying to use a query string parameter with a + in it? I want to use 'starttimetime' with value '2017-04-05T11:48:59+02:00'. Eventually this is being sent with a space.

I debugged it and this is caused by the Request::getArrayFromQuerystring function that uses parse_str. This decodes the + sign to a space.

@AdrianMeresescu
Copy link

Hello,

Will this pull request be merged any time soon ?

I have a similar issues when sending multiple tags (eg. someUrl?tags[]=php&tags[]=unirest). Unirest strips the second parameters resulting in someUrl?tags[]=php.

Thanks!

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Andrea seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants