[Core] Fix fulldebug in windows #13222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenzorrilla
approved these changes
Mar 13, 2025
|
I confirm that now it compiles in Windows FullDebug :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
FullDebug builds in windows were failing for some people.
The cause is that, for some reason, now it defaults to
/MDinstead of/MDd. 🤷 @AlejandroCornejo This should fix your problem.Also took the chance to prepare the CMake to use the new findboost, just setting the policy for now ( @rfaasse we will need this prior to upgrading boost and cmake to newer versions because they changed how the FindBoost works from 3.30 onwards and newer versions of boost are designed to work with that )
🆕 Changelog