txt records per hostname and owner #461
Conversation
| Record will be created with one target per key/value pair. | ||
| Controller will be able to read records that will have multiple key/value pairs in one target. Also, if there are no extra labels to be stored the target will be `""` (not and empty string!) | ||
|
|
||
| TXT records are stored alongside endpoints in the provider. Note that the deletion of the DNSRecord/endpoint not always results in the deletion of the corresponding endpoint in the provider but will always result in the deletion of the corresponding TXT record. The same is true about creation. This is because multiple owners can define the same endpoint, but they will always define unique TXT records. |
There was a problem hiding this comment.
Ignore this doc - I'll do it the last
There was a problem hiding this comment.
Updated. Hope this makes sense. I'm lacking in experience writing docs, but hopefully, this time it went ok.
maksymvavilov
force-pushed
the
gh-346-2
branch
4 times, most recently
from
f3a5d92 to
800baef
Compare
There was a problem hiding this comment.
I pulled this down and went through each provider using the multi record test, trying a few different combinations of records. It appears to create records correctly, but there are some issues with updates and deletes, in particular on GCP. I left some comments where i think you need to look at the code again relating to that, and also had a go at explaining how the length of the expected endpoints is being calculated for each provider in the tests.
I have not gone too deep into the code around labelling tbh, will wait and see where it ends up after you fix the issues with failing tests.
maksymvavilov
force-pushed
the
gh-346-2
branch
2 times, most recently
from
b71d4e7 to
7fd3c1b
Compare
| --type=kuadrant.io/azure \ | ||
| --from-file=azure.json=/local/path/to/azure.json | ||
| ``` |
There was a problem hiding this comment.
This one has nothing tto do with this PR but hope it will slide - just a formating of an .md
| a.Targets.Same(b.Targets) && | ||
| a.RecordType == b.RecordType && | ||
| a.SetIdentifier == b.SetIdentifier && | ||
| a.RecordTTL == b.RecordTTL && | ||
| SameProviderSpecific(a.ProviderSpecific, b.ProviderSpecific) |
There was a problem hiding this comment.
Why are you removing the check on the labels being the same here? What implications does that have? Where is SameEndpoint being used currently?
There was a problem hiding this comment.
Included labels check into the SameEndpoints()
The reason for the separation was to explicitly check for all labels in a few places. Rolled back to only check owner key
maksymvavilov
force-pushed
the
gh-346-2
branch
2 times, most recently
from
73c0e32 to
b1b4e62
Compare
Signed-off-by: Maskym Vavilov <[email protected]>
maksymvavilov
force-pushed
the
gh-346-2
branch
2 times, most recently
from
8fdc67c to
98dac52
Compare
Signed-off-by: Maskym Vavilov <[email protected]>
closes #346
Rewrite of the TXT registry to create TXT records per owner.