Closed
Conversation
Contributor
|
I can work with you on this in the near future using our lab's system. |
for more information, see https://pre-commit.ci
This was referenced Sep 16, 2025
Merged
Member
Author
|
@drammock if you come back to this... really I think we should try to avoid any manual OpenGL calls if at all possible. I'd actually start from seeing if we could eliminate all of that stuff and use Pyglet to choose a double-buffered display etc. and do all our draws. Then check that the timing is good on that branch... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This at least moves us toward compatibility with pyglet-master by using modern OpenGL to do our post-flip draw. It actually doesn't yet generate proper visuals on pyglet
master, TBD why. Probably some OpenGL state thing...To merge this I think we need someone to have a system with reliable scope timing on
mainwho can then test that things are still good on this branch. I can set this up someday on my proper Windows boot, but for now I'll just open this so we can have something to work from eventually.