Overdue commit for dual-monitor display fix #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note from SMB: These changes have been sitting on Newnin (newest stim computer in the I-LABS MEG lab) for some time. The line changes in _exp_controller were necessary for some dual-monitor and projector displays . I think sync_test_dualmon.py was created at the time to test lag times with the new setup. Per the requested merge: We only have the one computer with which to test the display functionality, but I can attest that the screen.x | screen.y trick was necessary and doesn't seem to conflict with other uses of ExpyFun.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note from SMB: These changes have been sitting on Newnin (newest stim computer in the I-LABS MEG lab) for some time. The line changes in _exp_controller were necessary for some dual-monitor and projector displays . I think sync_test_dualmon.py was adapted from the existing sync_test.py at the time to test lag times with the new setup.
Per the requested merge: We only have the one computer with which to test the display functionality, but I can attest that the
screen.x|screen.y trickwas necessary and doesn't seem to conflict with other uses of ExpyFun.