Update property patch #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamtry
reviewed
Mar 28, 2025
Comment on lines
+82
to
+85
| patchId = patch['id'] | ||
| areaId = patch['parentId'] | ||
| asset["patchId"] = patchId if patchId else None | ||
| asset["areaId"] = areaId if areaId else None |
Contributor
There was a problem hiding this comment.
Not a big deal but this would be more robust. ".get" returns None if the value isn't found but [] raises an error
asset["patchId"] = patch.get("id")
asset["areaId"] = patch.get("parentId")
adamtry
reviewed
Mar 28, 2025
| OUTPUT_CLASS = Asset | ||
| LOGGER = Logger() | ||
| STAGE = Stage.HOUSING_STAGING | ||
| ITEM_COUNT_LIMIT = 10 # Set to None to return all items |
Contributor
There was a problem hiding this comment.
Note you're not using this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update property patch script which updated the areaid and patchid in a asset dynamodb record.
All tested and working in staging
other small changes added previously: