Upgrade to next 13 #1027
Open
Upgrade to next 13 #1027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LBHCallumM
commented
Apr 11, 2025
Comment on lines
+58
to
+68
| - run: | ||
| name: Install Xvfb | ||
| command: | | ||
| sudo apt-get update | ||
| sudo apt-get install -y xvfb libgtk-3-0 libnotify-dev libgconf-2-4 libnss3 libxss1 libasound2 | ||
| - run: | ||
| name: Start Xvfb | ||
| command: | | ||
| Xvfb :99 -screen 0 1280x1024x24 & | ||
| echo "export DISPLAY=:99" >> $BASH_ENV | ||
| background: true |
Member
Author
There was a problem hiding this comment.
Apparently this is needed for cypress to run well in circleci
LBHCallumM
commented
Apr 11, 2025
Comment on lines
10
to
+26
| "parserOptions": { | ||
| "ecmaVersion": 2020, | ||
| "ecmaVersion": 2022, | ||
| "sourceType": "module", | ||
| "ecmaFeatures": { | ||
| "jsx": true | ||
| } | ||
| }, | ||
| "plugins": ["react", "@typescript-eslint"], | ||
| "plugins": [ | ||
| "react", | ||
| "react-hooks", | ||
| "@typescript-eslint" | ||
| ], | ||
| "extends": [ | ||
| "eslint:recommended", | ||
| "plugin:@typescript-eslint/recommended", | ||
| "plugin:react/recommended", | ||
| "plugin:prettier/recommended", | ||
| "plugin:react-hooks/recommended", |
LBHCallumM
commented
Apr 11, 2025
| .sentryclirc | ||
|
|
||
| # Version control | ||
| yarn.lock |
Member
Author
There was a problem hiding this comment.
Added yarn.lock back to vc, we should really be deploying with the same versions
LBHCallumM
commented
Apr 11, 2025
| let reporterRules = require('./reporter-rules.json') | ||
|
|
||
| module.exports = { | ||
| testEnvironment: 'jsdom', |
LBHCallumM
commented
Apr 11, 2025
| "loglevel": "^1.8.0", | ||
| "mockdate": "^3.0.2", | ||
| "next": "^12", | ||
| "next": "13", |
LBHCallumM
commented
Apr 11, 2025
Comment on lines
+73
to
+74
| it('closes the details panel after the enter key is pressed', async () => { | ||
| const user = userEvent.setup() |
LBHCallumM
commented
Apr 11, 2025
Comment on lines
+77
to
+79
| const tenants = contacts?.filter?.((x) => x.tenureType === 'Tenant') ?? [] | ||
| const householdMembers = | ||
| contacts?.filter?.((x) => x.tenureType === 'HouseholdMember') ?? [] |
LBHCallumM
commented
Apr 11, 2025
|
|
||
| const axios = require('axios') | ||
|
|
||
| jest.mock('next/router', () => ({ useRouter: jest.fn() })) |
LBHCallumM
commented
Apr 11, 2025
Comment on lines
30
to
36
| if ( | ||
| formState.rateScheduleItems.length < | ||
| arrayOfRateScheduleItemComponentIndexes.length | ||
| formState?.rateScheduleItems && | ||
| formState?.rateScheduleItems.length < | ||
| arrayOfRateScheduleItemComponentIndexes.length | ||
| ) { | ||
| arrayOfRateScheduleItemComponentIndexes.pop() | ||
| } |
Member
Author
There was a problem hiding this comment.
Fix bug when rateScheduleItems is null
LBHCallumM
commented
Apr 11, 2025
| } | ||
| } | ||
| }, arrayOfRateScheduleItemComponentIndexes) | ||
| }, [arrayOfRateScheduleItemComponentIndexes]) |
Member
Author
There was a problem hiding this comment.
how did this ever work without a dependency array
LBHCallumM
commented
Apr 11, 2025
Comment on lines
-104
to
-109
| await act(async () => { | ||
| await waitForElementToBeRemoved([ | ||
| screen.getByTestId('spinner-locationAlerts'), | ||
| screen.getByTestId('spinner-personAlerts'), | ||
| ]) | ||
| }) |
Member
Author
There was a problem hiding this comment.
Remove old act syntax
LBHCallumM
commented
Apr 11, 2025
Comment on lines
+14
to
24
| ? 'Reschedule appointment (non DRS)' | ||
| : 'Schedule appointment (non DRS)' | ||
|
|
||
| return ( | ||
| <> | ||
| <Link href={href}> | ||
| <a className="lbh-link">{linkText} (non DRS)</a> | ||
| <Link | ||
| href={href} | ||
| className="lbh-link" | ||
| > | ||
| {linkText} | ||
| </Link> |
Member
Author
There was a problem hiding this comment.
Move (non DRS) to linkText
LBHCallumM
commented
Apr 11, 2025
| setLoading(false) | ||
| } | ||
|
|
||
| useEffect(async () => { |
Member
Author
There was a problem hiding this comment.
Fix useEffect by moving async logic into a function
LBHCallumM
commented
Apr 11, 2025
Comment on lines
+19
to
+21
| const onSubmit = async (e) => { | ||
| e.preventDefault() | ||
|
|
Member
Author
There was a problem hiding this comment.
Prevent form from reloading page within cypress tests
LBHCallumM
commented
Apr 11, 2025
Comment on lines
+51
to
62
| const onGetToSummary = (data) => { | ||
| updateExistingTasksQuantities(data, tasks) | ||
|
|
||
| setAddedTasks( | ||
| e.rateScheduleItems | ||
| ? e.rateScheduleItems | ||
| .filter((e) => e != null) | ||
| .map((e, index) => { | ||
| return { id: index, ...e, code: e.code.split(' - ')[0] } | ||
| data.rateScheduleItems | ||
| ? data.rateScheduleItems | ||
| .filter((data) => data != null) | ||
| .map((data, index) => { | ||
| return { id: index, ...data, code: data.code.split(' - ')[0] } | ||
| }) | ||
| : [] | ||
| ) |
LBHCallumM
commented
Apr 11, 2025
| @@ -1,4 +1,4 @@ | |||
| import { v4 as uuidv4 } from 'uuid' | |||
| const { v4: uuidv4 } = require('uuid') | |||
Member
Author
There was a problem hiding this comment.
Eslint doesnt like this package due to MJS (no recent updates). The options were to replace the package, or change the import syntax
FaisalHackney
approved these changes
Apr 11, 2025
Duslerke
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://nextjs.org/docs/pages/building-your-application/upgrading/version-13
https://nextjs.org/docs/messages/invalid-new-link-with-extra-anchor