Upgrade to Next@15 #1247
Open
Upgrade to Next@15 #1247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LBHCallumM
commented
Nov 4, 2025
Comment on lines
-219
to
-229
| // Configure cookie removal in Sentry scope | ||
| Sentry.getCurrentScope().addEventProcessor((event) => { | ||
| if (event.request?.cookies[GSSO_TOKEN_NAME]) | ||
| event.request.cookies[GSSO_TOKEN_NAME] = '[REMOVED]' | ||
|
|
||
| if (event.request?.cookies[NEXT_PUBLIC_DRS_SESSION_COOKIE_NAME]) | ||
| event.request.cookies[NEXT_PUBLIC_DRS_SESSION_COOKIE_NAME] = | ||
| '[REMOVED]' | ||
|
|
||
| return event | ||
| }) |
Member
Author
There was a problem hiding this comment.
Rm server-side sentry config
LBHCallumM
commented
Nov 4, 2025
Comment on lines
+21
to
+30
| let isReady = false | ||
| let nextRequestHandler | ||
|
|
||
| server.all('*', (req, res) => nextRequestHandler(req, res)) | ||
| async function init() { | ||
| if (!isReady) { | ||
| await app.prepare() | ||
| nextRequestHandler = app.getRequestHandler() | ||
| isReady = true | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
Track when application is ready
LBHCallumM
commented
Nov 4, 2025
| > | ||
| <TD className="lbh-body-xs"> | ||
| <Link href={`/work-orders/${reference}`}> | ||
| <Link href={`/work-orders/${reference}`} legacyBehavior> |
Member
Author
There was a problem hiding this comment.
Add legacyBehavior tag because links containing an anchor tag is now depricated
LBHCallumM
commented
Nov 4, 2025
Comment on lines
-39
to
-47
| const { NODE_ENV, SENTRY_RELEASE } = process.env | ||
|
|
||
| const sentryWebpackPluginOptions = { | ||
| dryRun: !(NODE_ENV === 'production'), | ||
| release: SENTRY_RELEASE, | ||
| silent: !(NODE_ENV === 'production'), | ||
| } | ||
|
|
||
| module.exports = withSentryConfig(moduleExports, sentryWebpackPluginOptions) |
LBHCallumM
commented
Nov 4, 2025
Comment on lines
+1
to
+10
| { | ||
| "name": "repairs-hub-frontend", | ||
| "version": "0.1.0", | ||
| "private": true, | ||
| "dependencies": { | ||
| "restana": "^4.8.0", | ||
| "serve-static": "^1.14.1", | ||
| "serverless-http": "^2.6.0" | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
Add package.json for lambda.js file, to minimize bundle size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
legacyBehaviourtag for links. These can be upgraded in a future PRToo many changes to list everything, so may be better to ask questions.
I am due to do some extensive smoke testing to ensure no functionality is lost. But with a PR this size, its inevitable something will break.